-
Notifications
You must be signed in to change notification settings - Fork 246
Update TilesetViewGroup to have information about their associated credits #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update TilesetViewGroup to have information about their associated credits #1270
Conversation
… is referenced or not
…uce new referencer for raster overlay credits;
|
Thanks @ludovic-cheval-bentley-systems for opening this PR! @kring do you mind taking a look? |
|
Just realized this PR is still marked as draft; @ludovic-cheval-bentley-systems let us know when it's officially ready for review. |
|
@ludovic-cheval-bentley-systems now that this is passing CI, go ahead and hit that "Ready for review" button and we'll take a look. Unless there is more you want to do with it first? |
|
Thanks again for the PR @ludovic-cheval-bentley-systems. It looks good, but I have a couple of questions about use-cases.
|
By calling getSnapshot on a CreditSystem, clients can retrieve the current set of active credits. However, this snapshot represents credits across all TilesetViewGroups.
Some clients need to display credits separately for each viewport. To support this, new isCreditReferenced methods have been added to both CreditReferencer and TilesetViewGroup. These allow clients to check whether credits obtained from the CreditSystem apply to a specific TilesetViewGroup.
Similarly, certain clients must distinguish credits originating from raster overlays from other credits. To enable this, a dedicated CreditReferencer has been introduced within TilesetViewGroup to reference raster overlay credits. The existing CreditReferencer continues to reference all credits associated with the TilesetViewGroup.